[plsql] Fix ignored WITH clause for SELECT INTO statements #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
adangel
approved these changes
Feb 16, 2024
| @@ -1279,6 +1279,7 @@ void AbstractSelectStatement(AbstractSelectStatement node) #void : | |||
| ASTSelectIntoStatement SelectIntoStatement() : | |||
| {} | |||
| { | |||
| [ WithClause() ] // Although undocumented, WITH works with SELECT INTO ! | |||
There was a problem hiding this comment.
Indeed, this is missing in the official reference doc: https://docs.oracle.com/en/database/oracle/oracle-database/23/lnpls/SELECT-INTO-statement.html#GUID-6E14E04D-4344-45F3-BE80-979DD26C7A90
For "normal" SELECT statements, the WithClause is defined: https://docs.oracle.com/en/database/oracle/oracle-database/23/sqlrf/SELECT.html#GUID-CFA006CA-6FF1-4972-821E-6996142A51C6
adangel
changed the title
adangel
added a commit
that referenced
this pull request
Feb 16, 2024
adangel
added a commit
that referenced
this pull request
Feb 16, 2024
[plsql] Fix ignored WITH clause for SELECT INTO statements #4825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Related issues
none that I know
Fixes [plsql] WITH clause is ignored for SELECT INTO statements #4820
Ready?
./mvnw clean verifypasses (checked automatically by github actions)