Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1084 [Java] add extra assert method names to Junit rules #4864

Merged
merged 7 commits into from Apr 4, 2024
Merged

Fix #1084 [Java] add extra assert method names to Junit rules #4864

merged 7 commits into from Apr 4, 2024

Conversation

emouty
Copy link
Contributor

@emouty emouty commented Mar 20, 2024

Describe the PR

Added a parameter extraAssertMethodNames to rules that were using TestFrameworksUtil.isProbableAssertCall (JUnitTestsShouldIncludeAssertRule and JUnitTestContainsTooManyAssertsRule)

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@emouty emouty force-pushed the parametrize-assert-methods branch from 87f957e to 42f78b6 Compare March 20, 2024 11:17
@emouty emouty marked this pull request as ready for review March 20, 2024 11:18
@adangel adangel added this to the 7.1.0 milestone Mar 21, 2024
@pmd-test
Copy link

pmd-test commented Mar 21, 2024 •
edited

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 52 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
✅ Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel added the an:enhancement An improvement on existing features / rules label Mar 25, 2024
@adangel adangel modified the milestones: 7.1.0, 7.0.1 Apr 3, 2024
adangel
adangel approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

adangel added a commit that referenced this pull request Apr 4, 2024
@adangel
[doc] Update release notes (#1084, #4864)
2174fc2
adangel added a commit that referenced this pull request Apr 4, 2024
@adangel
Merge pull request #4864 from emouty:parametrize-assert-methods
b1c40f1 
Fix #1084 [Java] add extra assert method names to Junit rules #4864
@adangel adangel merged commit e10f622 into pmd:master Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
an:enhancement An improvement on existing features / rules
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

[java] Allow JUnitTestsShouldIncludeAssert to configure verification methods
4 participants
@emouty @pmd-test @adangel @oowekyala