[core] Add a filter possibility to FileCollector #4956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This adds a new API method in FileCollector in order to filter files before they are added.
Needed to fix #4942. The logic is the same as in PMD 6, meaning: if the filename (not the path) is the same and the file size, then the file is considered a duplicate.
We could do a checksum comparison or something like that, but this would then a behavioral change or a new feature.
Related issues
--skip-duplicate-files
has no effect (7.0.0 regression) #4942Ready?
./mvnw clean verify
passes (checked automatically by github actions)