Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reproducible build issues with 7.0.0 #4967

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Fix reproducible build issues with 7.0.0 #4967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9dcaae
Bump maven-source-plugin from 3.3.0 to 3.3.1
adangel Apr 18, 2024
4b14d4e
Use latest ant for maven-antrun-plugin
adangel Apr 18, 2024
53aecb6
Exclude pmd-cli/pmd-dist from cyclonedx BOM
adangel Apr 18, 2024
b42108d
[doc] Update release notes (#4967)
adangel Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/pages/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ This is a {{ site.pmd.release_type }} release.
* [#4886](https://github.com/pmd/pmd/issues/4886): \[java] BigIntegerInstantiation: False Positive with Java 17 and BigDecimal.TWO
* pom-errorprone
* [#4388](https://github.com/pmd/pmd/issues/4388): \[pom] InvalidDependencyTypes doesn't consider dependencies at all
* misc
* [#4967](https://github.com/pmd/pmd/pull/4967): Fix reproducible build issues with 7.0.0

### 🚨 API Changes

Expand Down
20 changes: 19 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,12 @@
<artifactId>javacc</artifactId>
<version>${javacc.version}</version>
</dependency>
<!-- Use the latest ant version to preserve file permissions when doing replaceregexp -->
<dependency>
<groupId>org.apache.ant</groupId>
<artifactId>ant</artifactId>
<version>${ant.version}</version>
</dependency>
</dependencies>
</plugin>
<plugin>
Expand Down Expand Up @@ -361,7 +367,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.3.0</version>
<version>3.3.1</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down Expand Up @@ -750,6 +756,18 @@
<goals>
<goal>makeAggregateBom</goal>
</goals>
<configuration>
<!-- PMD is released in two phases: first everything without pmd-cli/pmd-dist
(profile cli-dist-modules disabled), and then only pmd-cli/pmd-dist.
The BOM for the main artifact net.sourceforge.pmd:pmd is created and published
in the first phase and doesn't contain pmd-cli/pmd-dist. In order to be able
to reproduce the BOM, we exclude this two modules always.
-->
<excludeArtifactId>
<artifactId>pmd-cli</artifactId>
<artifactId>pmd-dist</artifactId>
</excludeArtifactId>
</configuration>
</execution>
</executions>
</plugin>
Expand Down