[core] Rule Violation Fixes applier flow for AST #856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsotuyod
reviewed
Jan 28, 2018
| * @param applicableCompilationUnits the list of applicable compilation units on which to apply and fix the rules | ||
| * @param context the context which the visitors will have | ||
| */ | ||
| public void applyWithAutoFixes(final List<? extends Node> applicableCompilationUnits, final RuleContext context) { |
There was a problem hiding this comment.
do we really need to copy / paste 30+ lines to have an exact duplicate of apply that merely adds a context.getRuleViolationFixesApplier().applyAutoFixesAndClear();?
| * @param context the context passed to the visitors | ||
| * @param language The AST source | ||
| */ | ||
| public void applyWithAutoFixes(final List<Node> applicableCompilationUnits, final RuleContext context, final Language language) { |
| /** | ||
| * Apply, in order of insertion, the auto fixes for the nodes. In the end it calls the {@link #clear()} method. | ||
| */ | ||
| public void applyAutoFixesAndClear() { |
There was a problem hiding this comment.
what's the benefit in reusing the same instance? Why do we keep both versions of these methods? It seems to me we will always want to use the later, and that it's a hack just to avoid instantiating more RuleViolationFixesApplier. To what end, I'm not sure
jsotuyod
added
the
is:WIP
|
We are closing this as it has been deprecated in favor of a new autofixes approach. See #693. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #693:
RuleViolationFix operations for AST should be stored and applied after application of rule chain and application of every rule so that the following rule may have the most updated representation of the AST.
Additions
Note
Consider looking only at the following commit which is dependant on the commits of #850: e9a3070. After merging the mentioned PR, this note can be deleted.