[core] Add Rewrite Events #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Node interface
- Add insert method to insert new children in certain indexes
- Add replace method to replace current children with new ones in certain indexes
- Rename removeChildAtIndex method to remove with an index parameter
- Fix test cases to match the new convention
- Implement insert & replace methods in AbstractNode
- Add test cases for the new features
- Leave some TODOs related to the autofix flow
- NodeEvents will be implemented soon; that's why these TODOs were left in the code
- Add main classes to support Rewrite Events
- Update AbstractNode to record rewrite events over children nodes
- Add test cases for implemented functionality
- Fix test cases
- It would be nice to disable the `haveChildrenChanged` property in xpath.
This would allow to leave test cases as they were, but I actually don't know
how to achieve this. So, for the momment,
I've added this new field to the test cases
14 tasks
MatiasComercio
commented
Jan 22, 2018
| @@ -32,7 +32,7 @@ public void testAttributeAxisIterator() { | |||
| Attribute attribute = it.next(); | |||
| atts.put(attribute.getName(), attribute); | |||
| } | |||
| Assert.assertEquals(7, atts.size()); | |||
| Assert.assertEquals(8, atts.size()); | |||
There was a problem hiding this comment.
It would be nice to disable the haveChildrenChanged property in xpath.
MatiasComercio
commented
Jan 22, 2018
| @@ -28,6 +28,7 @@ public void testCopyXmlToClipboard() { | |||
| String xml = Designer.getXmlTreeCode(compilationUnit); | |||
| assertEquals("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" | |||
| + "<dummyNode BeginColumn=\"1\" BeginLine=\"1\" EndColumn=\"0\" EndLine=\"0\" FindBoundary=\"false\"\n" | |||
| + " Image=\"Foo\"\n" + " SingleLine=\"false\"/>", xml); | |||
| + " Image=\"Foo\"\n" + " SingleLine=\"false\"\n" | |||
| + " haveChildrenChanged=\"false\"/>", xml); | |||
There was a problem hiding this comment.
It would be nice to disable the haveChildrenChanged property in xpath.
gibarsin
reviewed
Jan 22, 2018
| * </p> | ||
| * <p> | ||
| * Rewrite events occurring on the same index are merged straight away, so at all moment only one rewrite event | ||
| * is hold for a given index. This helps to understand exactly what kind of change has the node suffer, |
There was a problem hiding this comment.
Change suffer to suffered
There was a problem hiding this comment.
I'd add that "hold" should be "held"
|
Thanks for yet another PR. I've briefly reviewed this changeset, but I have two problems with it.
|
jsotuyod
added
the
is:WIP
|
We are closing this as it has been deprecated in favor of a new autofixes approach. See #693. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #858 ==> Start review from commit 41c3684
PR Description
Implements: #693: Generate & identify events over AST nodes
List of changes
haveChildrenChangedproperty in xpath. This would allow to leave test cases as they were, but I actually don't know how to achieve this. So, for the moment, I've added this new field to the test cases.