[java] Add ignoredAnnotations property to unusedPrivateMethod rule #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djydewang this looks very good! Remember to transform the set in |
|
@djydewang oh! I missed that! awesome! |
oowekyala
reviewed
Mar 5, 2018
| * the node to check | ||
| * @return <code>true</code> if the annotation has been found | ||
| */ | ||
| protected boolean hasNeglectAnnotation(MethodNameDeclaration node) { |
There was a problem hiding this comment.
Maybe this should be enough of a common pattern (checking if a node has an annotation in a particular set) that we could move that logic to ASTMethodDeclaration someday. Otherwise it'll be duplicated in every rule that needs it...
There was a problem hiding this comment.
Same logic here.
adangel
changed the title
jsotuyod
added a commit
that referenced
this pull request
Mar 11, 2018
|
This is now merged and will be part of PMD 6.2.0. Thanks a lot @djydewang! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issue #907