Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v8::Local handles everywhere #114

Merged
merged 4 commits into from
Jul 17, 2019
Merged

Use v8::Local handles everywhere #114

merged 4 commits into from
Jul 17, 2019

Conversation

tim-janik
Copy link
Contributor

@tim-janik tim-janik commented Jul 17, 2019

Fix the remaining v8::Handle occourances, including the docs & examples, so users are not mislead into using deprecated/removed types.

Signed-off-by: Tim Janik <timj@gnu.org>
Signed-off-by: Tim Janik <timj@gnu.org>
Signed-off-by: Tim Janik <timj@gnu.org>
Signed-off-by: Tim Janik <timj@gnu.org>
@pmed pmed merged commit 207859d into pmed:master Jul 17, 2019
@pmed
Copy link
Owner

pmed commented Jul 17, 2019

Hi @tim-janik

Thank you a lot for the fix!

@tim-janik tim-janik deleted the local-handles branch July 19, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants