-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Frame
methods to compute overlaps; remove current resampling.py
#219
Comments
Here is an associated problem I stumbled over: why do frames have boxes at all, instead of just shapes? Here's the problem. When we define a model frame with an non-zero You can see the problem also if you consider cases with more than two images that are offset wrt each other, even at the same resolution. We cannot define the So, in the multi-observation case, we can do two things instead of offsetting the model frame with a non-zero
The first opton is the cheap fix. I prefer option 2 for two reasons: It yields a WCS we can report for the entire model. And it allows us to remove |
Actually, option 1 is only working with a lot of care because its pixels index is what is needed for its own WCS transformation if we ignore I think the only clean way is to let Frames have simple shapes, and define WCSs whenever we work with more than one observation. |
After thinking this over I agree that in principle you are right that the |
I think |
Originally posted by @herjy in #217 (comment)
Current methods in
resampling.py
are largely superseded by WCS transformations inFrame
. The only missing methods ismatch_patches
, which could easily be ported to Frame as well asFrame.intersect(other_frame)
.The text was updated successfully, but these errors were encountered: