Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSC PSFs truncated -> create ringing in LowResObservation #225

Open
pmelchior opened this issue Dec 3, 2020 · 1 comment
Open

HSC PSFs truncated -> create ringing in LowResObservation #225

pmelchior opened this issue Dec 3, 2020 · 1 comment
Assignees

Comments

@pmelchior
Copy link
Owner

The multi-resolution tutorial uses a HSC PSF with 31 pixels. This is apparently too small and creates ringing in the oversampled PSF (which defines the diff kernel):

plt.imshow(obs_hsc._diff_kernels.image[4], vmax=1e-6)

yields
download
Other HSC bands are similar. This should affect the results of the resampling+convolution operation.

This issue addresses two aspects:

  • Confirm whether the ringing is detrimental for the convergence or accuracy of multi-observation fitting
  • If so, create code to check for this problem before we run the fitter
@fred3m
Copy link
Collaborator

fred3m commented Dec 3, 2020

HSC PSFs are usually 41x41 or 43x43 pixels. So you should be able to test with the full HSC PSF to see if truncation is the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants