Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #124

Merged
merged 7 commits into from
Jul 12, 2019
Merged

Cleanup #124

merged 7 commits into from
Jul 12, 2019

Conversation

pmelchior
Copy link
Owner

This PR addresses issues #106, #109, #111, and a bit of #121. No feature changes, just consistency and avoidance of type casting.

@pmelchior pmelchior requested a review from herjy July 11, 2019 16:30
fred3m
fred3m reviewed Jul 11, 2019
View reviewed changes
Copy link
Collaborator

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, it was a necessary set of changes that I'm sure was more tedious than fun. I made a couple of small comments but other than that it looks good.

scarlet/observation.py Outdated Show resolved Hide resolved
tests/test_component.py Outdated Show resolved Hide resolved
@pmelchior pmelchior requested review from fred3m and removed request for herjy July 12, 2019 01:40
fred3m
fred3m approved these changes Jul 12, 2019
View reviewed changes
Copy link
Collaborator

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a merge conflict with Remy's branch that just merged. Fix that and this should be ready to merge.

@pmelchior pmelchior merged commit 448d48d into master Jul 12, 2019
@pmelchior pmelchior deleted the cleanup branch July 12, 2019 02:02
@pmelchior pmelchior mentioned this pull request Jul 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred3m fred3m fred3m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmelchior @fred3m