-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix sed #126
Bugfix sed #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of only using positive values of the sed but I have a design question and a question about a negativity check in my comments below.
….symmetric gets explicit pixel_center
@fred3m , I've addressed all comments, and created a simpler implementation of MultiComponentSource that actually uses a common center for all components. You can merge if you are fine with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. Everything looks good except that I didn't quite like the change in MulitComponentSource
where you removed the update function from the individual components and instead put them in the parents update function. While it works fine this way I think that it goes against our design pattern of having child components with update functions and a parent that just updates the children. Feel free to push back if you feel that I'm being too rigid.
SED initialization code was not robust for negative/zero flux in some bands. As such, such an SED is not a problem. I therefore changed the behavior from raising an exception to logging a warning.
I also, moved the SED correction (for PSF width variations) from
get_pixel_sed
to the relevantinit_
functions because this is where it's needed. It's confusing otherwise.