-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamlining #206
Streamlining #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. The only change that I requested is to make logger output an info
instead of a warning
to show the final logL, since this isn't really indicative of something that went wrong and will pollute peoples consoles/terminals.
scarlet/blend.py
Outdated
@@ -164,6 +167,12 @@ def expand_grads(*X, func=None): | |||
**alg_kwargs | |||
) | |||
|
|||
logger.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems more like info
than a warning
.
Of course, the docs are failing to build, as well as some changes that are needed in |
I will re-introduce As for |
dca4683
to
82aaa9c
Compare
This PR streamlines common tasks.
Blend.fit
writes logger message with number of iterations and final logLdisplay.show_likelihood
shows our convergence plots from a fitBlend
instance.display.show_observation
shows the image and PSF in common norm and size (likeshow_scene
but without sources)In the process, I renamed
loss
tolog_likelihood
in bothBlend
andObservation
, and fixed the stupid -1 for good.