Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioneering #209

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Versioneering #209

merged 2 commits into from
Sep 15, 2020

Conversation

fred3m
Copy link
Collaborator

@fred3m fred3m commented Sep 15, 2020

Strip out setuptools_scm for a more stable native implementation to use SCM tags for version control.

Copy link
Owner

@pmelchior pmelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of having to accommodate the LSST stack on our end, but if it doesn't break out stuff, so be it.

@fred3m
Copy link
Collaborator Author

fred3m commented Sep 15, 2020

I get that, but this is really making up for a shortcoming of setuptools_scm. The problem is they don't allow for non-version tags at all, so even if I wanted to just implement something on the lsst side (which was my original plan) I can't because when setuptools_scm tries to parse the non-version tags it can't and throws an error.

But this solution is better anyway because it's only a few lines of code to implement what takes them an entire obfuscated package that does God-only-knows what.

@fred3m fred3m merged commit 2190d11 into master Sep 15, 2020
@fred3m fred3m deleted the versioneering branch September 15, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants