Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid next_fast_len from deprecated helper namespace #279

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Avoid next_fast_len from deprecated helper namespace #279

merged 1 commit into from
Jun 21, 2023

Conversation

arunkannawadi
Copy link
Contributor

This patch avoids deprecation warnings.

 DeprecationWarning: Please use `next_fast_len` from the `scipy.fftpack` namespace, the `scipy.fftpack.helper` namespace is deprecated.

@pmelchior
Copy link
Owner

Does this require a minimum scipy version?

@arunkannawadi
Copy link
Contributor Author

scipy.fftpack.helper was marked as legacy in scipy 1.4.0: https://docs.scipy.org/doc/scipy-1.4.0/reference/fftpack.html

Currently (in scipy 1.10.0), even scipy.fftpack is considered legacy and the recommended usage of next_fast_len is from scipy.fft.

@pmelchior pmelchior merged commit 45187fd into pmelchior:master Jun 21, 2023
@arunkannawadi arunkannawadi deleted the next_fast_len branch June 21, 2023 22:39
@arunkannawadi arunkannawadi restored the next_fast_len branch June 21, 2023 22:39
@arunkannawadi arunkannawadi deleted the next_fast_len branch June 21, 2023 22:39
@timj timj mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arunkannawadi @pmelchior