Add compile option WITH_PMEM and runtime config enable_pmem #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yu, Peng <peng.yu@intel.com>
|
There will be another pull request to rename variables and update license headers. |
|
The original pull request to be split: #327 |
ZiyanShi
approved these changes
Sep 8, 2022
engine/allocator.hpp
Outdated
| uint64_t max_offset_; | ||
|
|
||
| bool thread_local_counter_enabled_{}; | ||
| std::vector<std::int64_t> thread_allocated_sizes_; |
There was a problem hiding this comment.
False sharing, potential bottleneck.
There was a problem hiding this comment.
I'd like to use std::int64_t* in next commit.
engine/dl_list.cpp
Outdated
| @@ -143,16 +143,20 @@ bool DLList::Replace(DLRecord* old_record, DLRecord* new_record, | |||
| old_record->PersistPrevNT(new_record_offset); | |||
| } else { | |||
| new_record->prev = prev_offset; | |||
| #ifdef KVDK_WITH_PMEM | |||
There was a problem hiding this comment.
Maybe we should redefine pmem_persist()/pmem_memcpy()/pmem_memmove() as macros for compiling without pmem so that we can reduce macros?
There was a problem hiding this comment.
Good suggestion. I find 7 locations where checking KVDK_WITH_PMEM could be removed with this improvement.
Signed-off-by: Yu, Peng <peng.yu@intel.com>
Signed-off-by: Yu, Peng <peng.yu@intel.com>
JiayuZzz
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: Introducing optional volatile KV storage on DRAM
What is changed and how it works?
What's Changed:
WITH_PMEM, which isONby defaultenable_pmeminKVDK::Configs, which istrueby default-DWITH_PMEM=OFFto remove dependency tolibpmem-DWITH_PMEM=ON, settingConfigs.enable_pmem=falsecan make KVDK store data on DRAMCheck List
Tests
Side effects