Cherry-pick volatile branch to release 1.0 of main branch #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yu, Peng <peng.yu@intel.com>
Signed-off-by: Jiayu Wu <jiayu.wu@intel.com>
Signed-off-by: Jiayu Wu <jiayu.wu@intel.com>
Signed-off-by: Jiayu Wu <jiayu.wu@intel.com>
iyupeng
reviewed
Oct 13, 2022
engine/allocator.hpp
Outdated
| @@ -192,8 +180,7 @@ class Allocator { | |||
| uint64_t max_offset_; | |||
|
|
|||
| bool thread_local_counter_enabled_{}; | |||
| uint32_t num_thread_local_counters{0}; | |||
| std::int64_t* thread_allocated_sizes_{nullptr}; | |||
| std::vector<int64_t> thread_allocated_sizes_{}; | |||
There was a problem hiding this comment.
std::vector is supposed to have potential bottleneck here. This was discussed before : #329 (review)
There was a problem hiding this comment.
I don't think std::int64* would resolve this problem, we need to align it to cache line
There was a problem hiding this comment.
OK. I misunderstood this problem.
There was a problem hiding this comment.
Will you do the alignment in this pull request?
iyupeng
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Cherry-pick volatile branch to release 1.0 of main branch
Check List
Tests