Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

Fix minor issues #106

Merged
merged 2 commits into from Nov 14, 2018
Merged

Fix minor issues #106

merged 2 commits into from Nov 14, 2018

Conversation

kkajrewicz
Copy link
Contributor

@kkajrewicz kkajrewicz commented Nov 14, 2018 •
edited by marcinslusarz

This change is Reviewable

@pmem-bot
Copy link
Contributor

@ldorau and @llugin please review this pull request

ldorau
ldorau reviewed Nov 14, 2018
View reviewed changes
Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Nov 14, 2018 •
edited

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files          26       26           
  Lines         987      987           
=======================================
  Hits          890      890           
  Misses         97       97
Flag Coverage Δ
#tests_clang_debug_cpp17 61.8% <ø> (ø) ⬆️
#tests_clang_release 61.39% <ø> (ø) ⬆️
#tests_gcc_debug 92.84% <ø> (ø) ⬆️
#tests_gcc_release_cpp17 88.6% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb1c90...2ee492c. Read the comment docs.

szyrom
szyrom reviewed Nov 14, 2018
View reviewed changes
Copy link

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

igchor
igchor reviewed Nov 14, 2018
View reviewed changes
Copy link
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

marcinslusarz
marcinslusarz approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@marcinslusarz marcinslusarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@marcinslusarz marcinslusarz merged commit 394d92e into pmem:master Nov 14, 2018
@kkajrewicz kkajrewicz deleted the minor-issues branch December 12, 2018 10:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ldorau ldorau ldorau left review comments

@szyrom szyrom szyrom left review comments

@igchor igchor igchor left review comments

@marcinslusarz marcinslusarz marcinslusarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kkajrewicz @pmem-bot @ldorau @szyrom @marcinslusarz @igchor