Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

[1.6] Add option to force define IS_TRIVIALLY_COPYABLE #325

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

igchor
Copy link
Contributor

@igchor igchor commented Jun 11, 2019

This change is Reviewable

@pmem-bot
Copy link
Contributor

@kkajrewicz and @wlemkows please review this pull request

Copy link

@szyrom szyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

btw. we should add CI runs with gcc 4.85 AND with clang 3.3

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor igchor changed the title Is trivially copyable 1.6 [1.6] Is trivially copyable Jun 11, 2019
@igchor igchor changed the title [1.6] Is trivially copyable [1.6] Add option to force define IS_TRIVIALLY_COPYABLE Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #325 into stable-1.6 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable-1.6    #325   +/-   ##
==========================================
  Coverage        96.5%   96.5%           
==========================================
  Files              30      30           
  Lines            2091    2091           
==========================================
  Hits             2018    2018           
  Misses             73      73
Flag Coverage Δ
#tests_clang_debug_cpp17 96.93% <ø> (ø) ⬆️
#tests_gcc_debug 97.88% <ø> (ø) ⬆️
#tests_gcc_release_cpp17_no_valgrind 96.63% <ø> (ø) ⬆️
Impacted Files Coverage Δ
include/libpmemobj++/detail/common.hpp 93.54% <ø> (ø) ⬆️
include/libpmemobj++/transaction.hpp 93.97% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bf223...e5c0fa5. Read the comment docs.

Copy link
Contributor

@kkajrewicz kkajrewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kkajrewicz kkajrewicz merged commit e1691a1 into pmem:stable-1.6 Jun 12, 2019
@igchor igchor deleted the is_trivially_copyable_1.6 branch October 7, 2019 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants