FEAT: pmempool feature --query should display all available pool features

[sscargal]

FEAT: pmempool feature --query should display all available pool features

Rationale

Currently, pmempool feature --query mandates the user to provide the feature they want to test. To improve usability, and to reduce the number of commands the user must run to establish all the information, pmempool feature should show all the available features and values in a single command.

#5072 requests all pool feature information be shown in the pmempool info command. This feature requests that the pool features be shown in pmempool feature command.

Description

There are multiple pool features available: SINGLEHDR, CKSUM_2K, SHUTDOWN_STATE, CHECK_BAD_BLOCKS. To establish if a pool has these features, the user is forced to check each in turn:

# pmempool feature --query SINGLEHDR /dev/dax0.0
0
# pmempool feature --query CKSUM_2K /dev/dax0.0
1
# pmempool feature --query SHUTDOWN_STATE /dev/dax0.0
1
# pmempool feature --query CHECK_BAD_BLOCKS /dev/dax0.0
1

To improve usability, it would be preferable to loop over all the available features and display their values. We could support this by providing no command, eg:

# pmempool feature /dev/dax0.0
POOL Features:
SINGLEHDR                : 0
CKSUM_2K                 : 1 
SHUTDOWN_STATE           : 1
CHECK_BAD_BLOCKS         : 1

Additionally, we could change the --query behaviour to optionally provide a feature. If no specific feature is specified, pmempool would show all available features, eg:

# pmempool feature --query /dev/dax0.0
POOL Features:
SINGLEHDR                : 0
CKSUM_2K                 : 1 
SHUTDOWN_STATE           : 1
CHECK_BAD_BLOCKS         : 1

The current behaviour would be maintained if the user specifies a feature to query.

# pmempool feature --query SINGLEHDR /dev/dax0.0
0

API Changes

None

Implementation details

TBD

Meta

N/A

[janekmi]

This improvement is not considered vital at the moment. So, we do not have the resources to fulfil your request. Sorry.