Fix various issues reported by PVS-Studio analysis #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported-by: Andrey Karpov <karpov@viva64.com>
Reported-by: Andrey Karpov <karpov@viva64.com>
Reported-by: Andrey Karpov <karpov@viva64.com>
Reported-by: Andrey Karpov <karpov@viva64.com>
Reported-by: Andrey Karpov <karpov@viva64.com>
Reported-by: Andrey Karpov <karpov@viva64.com>
Reported-by: Andrey Karpov <karpov@viva64.com>
Reported-by: Andrey Karpov <karpov@viva64.com>
Reported-by: Andrey Karpov <karpov@viva64.com>
Codecov Report
@@ Coverage Diff @@
## master #4942 +/- ##
==========================================
- Coverage 70.70% 70.44% -0.26%
==========================================
Files 157 176 +19
Lines 25895 27803 +1908
==========================================
+ Hits 18310 19587 +1277
- Misses 7585 8216 +631 |
lplewa
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Andrey Karpov and PVS-Studio for doing a thorough analysis of PMDK:
https://viva64.com/en/b/0756/
Even though we run two different static analysis tools and many runtime checkers, PVS-Studio managed to catch a couple of issues. The good news is that most of the problems were in tests or examples.
I didn't address the missing memory allocation error handling because while I 100% agree that library code should definitely handle all possible recoverable errors correctly, we usually omi extraneous error handling in tools/tests or benchmarks for the sake of brevity.
This change is