blk: set libpmemblk as deprecated #5538
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5538 +/- ##
==========================================
- Coverage 71.62% 71.36% -0.27%
==========================================
Files 162 162
Lines 24274 24384 +110
==========================================
+ Hits 17387 17401 +14
- Misses 6887 6983 +96 |
There was a problem hiding this comment.
Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)
doc/libpmemblk/libpmemblk.7.md line 306 at r1 (raw file):
> NOTICE: The **libpmemblk** library is deprecated since PMDK 1.12 release
1.13.0
osalyk
force-pushed
the
deprecated_blk
branch
from
e93267f
to
c2d8d9a
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)
doc/libpmemblk/libpmemblk.7.md line 306 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
1.13.0
Done.
There was a problem hiding this comment.
👍
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk)
No further support or maintenance of the libpmemblk library is planned. https://pmem.io/blog/2022/11/update-on-pmdk-and-our-long-term-support-strategy/ pmem/pmdk#5538
No further support or maintenance of the libpmemblk library is planned. https://pmem.io/blog/2022/11/update-on-pmdk-and-our-long-term-support-strategy/ pmem/pmdk#5538 Signed-off-by: osalyk <oksana.salyk@intel.com>
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 33 of 34 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Please check enum pmempool_pool_type in libpmempool.h
Reviewable status:
osalyk
force-pushed
the
deprecated_blk
branch
from
c2d8d9a
to
19559a3
Compare
There was a problem hiding this comment.
Done.
Reviewable status: 34 of 35 files reviewed, all discussions resolved (waiting on @grom72 and @lukaszstolarczuk)
| @@ -33,7 +33,7 @@ | |||
| */ | |||
|
|
|||
| /* | |||
| * info_blk.c -- pmempool info command source file for blk pool | |||
There was a problem hiding this comment.
Please update src/tools/pmempool/info.c
osalyk
force-pushed
the
deprecated_blk
branch
2 times, most recently
from
6c2775c
to
ac22ccf
Compare
There was a problem hiding this comment.
Done.
Reviewable status: 33 of 55 files reviewed, all discussions resolved (waiting on @grom72 and @lukaszstolarczuk)
There was a problem hiding this comment.
👍
Reviewed 1 of 1 files at r4, 22 of 22 files at r5, all commit messages.
Reviewable status:
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: BSD-3-Clause | |||
| /* Copyright 2014-2022, Intel Corporation */ | |||
| /* Copyright 2014-2023, Intel Corporation */ | |||
|
|
|||
| /* | |||
| * pmempool.c -- pmempool main source file | |||
There was a problem hiding this comment.
Using the blk function still does not display deprecated messages. The main help also does not provide this information.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wlemkows)
src/tools/pmempool/pmempool.c line 5 at r5 (raw file):
Previously, wlemkows (Weronika Lewandowska) wrote…
Using the blk function still does not display deprecated messages. The main help also does not provide this information.
Using attribute((deprecated())) we get information only during compilation.
Information about deprecated functions can be found in the help() and version() functions.
There was a problem hiding this comment.
Reviewed 4 of 22 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wlemkows)
There was a problem hiding this comment.
Reviewed 13 of 22 files at r5.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wlemkows)
| Libraries available in this repository: | ||
| - [libpmem](https://pmem.io/pmdk/libpmem/): provides low level persistent memory support. | ||
|
|
||
| - [libpmem2](https://pmem.io/pmdk/libpmem2/): provides low level persistent memory support, is a new version of libpmem. | ||
|
|
||
| - [libpmemobj](https://pmem.io/pmdk/libpmemobj/): provides a transactional object store, providing memory allocation, transactions, and general facilities for persistent memory programming. | ||
|
|
||
| - [libpmemblk](https://pmem.io/pmdk/libpmemblk/): supports arrays of pmem-resident blocks, all the same size, that are atomically updated. | ||
| - [libpmemblk](https://pmem.io/pmdk/libpmemblk/): supports arrays of pmem-resident blocks, all the same size, that are atomically updated. (DEPRECATED) | ||
|
|
There was a problem hiding this comment.
Please put NOTICE here, under libpmemblk line.
doc/pmempool/pmempool-info.1.md
Outdated
| # NOTE # | ||
|
|
||
| > NOTICE: | ||
| The **libpmemblk** library is deprecated since PMDK 1.13.0 release. |
There was a problem hiding this comment.
And btt is deprecated (because of line 78)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @osalyk)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @wlemkows)
README.md line 55 at r6 (raw file):
Previously, wlemkows (Weronika Lewandowska) wrote…
Please put NOTICE here, under libpmemblk line.
Done.
doc/pmempool/pmempool-info.1.md line 37 at r6 (raw file):
Previously, wlemkows (Weronika Lewandowska) wrote…
And btt is deprecated (because of line 78)
Done.
Code quote:
The **libpmemblk** library is deprecated since PMDK 1.13.0 release.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 3 files at r6, 2 of 2 files at r7, all commit messages.
Reviewable status:
No further support or maintenance of the libpmemblk library is planned. https://pmem.io/blog/2022/11/update-on-pmdk-and-our-long-term-support-strategy/ pmem/pmdk#5538 Signed-off-by: osalyk <oksana.salyk@intel.com>
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
This change is