Pmemobj error via ERR() instead of LOG(1,...

[grom72]

Requires:

• Replace ERR("!... ") with ERR_W_ERRNO #5965
• Replace ERR() by ERR_WO_ERRNO  #5966

---

This change is 

[janekmi]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72)

---

src/libpmemobj/tx.c line 2230 at r1 (raw file):

	ERR_WO_ERRNO("tx.cache.threshold parameter is deprecated");

	return 0;

Suggestion:

return -1;

---

src/libpmemobj/tx.c line 2245 at r1 (raw file):

	ERR_WO_ERRNO("tx.cache.threshold parameter is deprecated");

	return 0;

Suggestion:

return -1;

---

src/libpmemobj/ulog.c line 672 at r1 (raw file):

			&u->next) != 0) {
			/* this is fine, it will just use more pmem */
			ERR_WO_ERRNO("unable to free transaction logs memory");

It seems to continue with no consequences. It is hard to call this one even a warning TBH.

Code quote:

			/* this is fine, it will just use more pmem */
			ERR_WO_ERRNO("unable to free transaction logs memory");

[codecov]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6a9fea9) 68.50% compared to head (4f3473f) 68.51%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
+ Coverage   68.50%   68.51%   +0.01%     
==========================================
  Files         133      133              
  Lines       19650    19650              
  Branches     3260     3260              
==========================================
+ Hits        13462    13464       +2     
+ Misses       6188     6186       -2     

[grom72]

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi)

---

src/libpmemobj/tx.c line 2230 at r1 (raw file):

	ERR_WO_ERRNO("tx.cache.threshold parameter is deprecated");

	return 0;

Done.

---

src/libpmemobj/tx.c line 2245 at r1 (raw file):

	ERR_WO_ERRNO("tx.cache.threshold parameter is deprecated");

	return 0;

Done.

---

src/libpmemobj/ulog.c line 672 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

It seems to continue with no consequences. It is hard to call this one even a warning TBH.

Done.

[janekmi]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)