Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add out_log_va to white list #5986

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jan 29, 2024

Add out_log_va to the white list as it is no longer used in the release version.


This change is Reviewable

Add out_log_va to the white list as it is no longer used in the
release version.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 added the no changelog Add to skip the changelog check on your pull request label Jan 29, 2024
@grom72 grom72 requested a review from janekmi January 29, 2024 09:53
@grom72 grom72 added the sprint goal This pull request is part of the ongoing sprint label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (069c860) 68.53% compared to head (a465cfc) 68.52%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5986      +/-   ##
==========================================
- Coverage   68.53%   68.52%   -0.02%     
==========================================
  Files         133      133              
  Lines       19658    19658              
  Branches     3259     3259              
==========================================
- Hits        13472    13470       -2     
- Misses       6186     6188       +2     

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

a discussion (no related file):
An actually informative reproduction with the not_called.json artifact. 😁


@janekmi janekmi merged commit 97de0a8 into pmem:master Jan 30, 2024
8 checks passed
@grom72 grom72 deleted the call-stack-analysis-whitelist branch February 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants