-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix links to relative instead of absolute ones #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to add preview?
Reviewable status: 0 of 39 files reviewed, all discussions resolved
I could, but this is not as trivial as it was with Jekyll. I was thinking how to enable this generically for all users, but with no good solution yet. What you can do is clone my fork and run within the repo:
and you'll get a localhost version of it with no additional changes. I tested some of the new links and they all worked fine. |
Change your fork's gh page source to |
ok, cool, there's some solution for that. Anyhow, thanks @pbalcer, I forgot we deploy this into gh-pages, fixed now on my fork: https://lukaszstolarczuk.github.io |
quick grep on all 'https://pmem.io/' links and replace to '/' where it made sense; Only links generated by hugo can be replaced in that way. It makes more sense to use it that way, so you can use this website locally and still test all links.
ae91eed
to
59f881d
Compare
I've updated this PR with some more links and it's ready for review. I won't be doing the aforementioned updates/upgrades to the "deploy system". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 38 of 39 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
quick grep on all 'https://pmem.io/' links and replace to '/' where it made sense;
Only links generated by hugo can be replaced in that way.
It makes more sense to use it that way, so you can use this website
locally and still test all links.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)