Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

test: mt: introduce a mtt-framework-provided semaphores #1050

Closed
wants to merge 1 commit into from

Conversation

janekmi
Copy link

@janekmi janekmi commented May 8, 2021

These semaphores are dedicated to interprocess synchronization between the parent and the child processes.


This change is Reviewable

These semaphores are dedicated to interprocess synchronization between
the parent and the child processes.
Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)


tests/multithreaded/common/mtt.c, line 71 at r1 (raw file):

	/*
	 * XXX use sem_close() in a for-loop
	 */

sem_unlink() has to be used here too (with the appropriate name of the semaphore)

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)


tests/multithreaded/common/mtt.c, line 71 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…
	/*
	 * XXX use sem_close() in a for-loop
	 */

sem_unlink() has to be used here too (with the appropriate name of the semaphore)

... so names of the semaphores have to be stored too ...

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)


tests/multithreaded/common/mtt.c, line 71 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

... so names of the semaphores have to be stored too ...

... or generated here for the 2nd time.

@janekmi
Copy link
Author

janekmi commented Jul 26, 2021

Requires proposing a generally useful internal API for synchronizing interrelated execution taking place in two different processes. Closing for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants