Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

tools: perf: config.json.example cleanup #1184

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

janekmi
Copy link

@janekmi janekmi commented Jul 30, 2021

  • do not suggest values
  • remove variables which does not make sense because they are ment to
    be calculated during the execution:
    • FORCE_REMOTE_DIRECT_WRITE_TO_PMEM
    • BUSY_WAIT_POLLING
    • CPU_LOAD_RANGE
    • OUTPUT_FILE
  • remove debug variables

This change is Reviewable

- do not suggest values
- remove variables which does not make sense because they are ment to
  be calculated during the execution:
	- FORCE_REMOTE_DIRECT_WRITE_TO_PMEM
	- BUSY_WAIT_POLLING
	- CPU_LOAD_RANGE
	- OUTPUT_FILE
- remove debug variables
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@ldorau ldorau merged commit 100bed7 into pmem:master Jul 30, 2021
@janekmi janekmi deleted the tools-perf-config.json.example-cleanup branch December 30, 2021 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants