common: print a message in case pmem won't be able to be used #1200
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Patryk717)
a discussion (no related file):
Please fix the commit message. It is important for Gihub to track relationships between PRs and PRs and issues.
Ref: #1089
Note: # is crucial. Ref is for the human reader.
Ref: https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls (please read)
a discussion (no related file):
Please also change the commit message:
common: print a message in case pmem won't be able to be used
CMakeLists.txt, line 108 at r1 (raw file):
if(NOT LIBPMEM_FOUND) message(WARNING "Libpmem is missing. The examples will be unable to use PMem. They will be using DRAM instead.") endif()
After reconsideration, I recommend a small change: Since libpmem is missing, the examples will be...
Sorry. ;-)
janekmi
changed the title
Patryk717
force-pushed
the
all_examples
branch
from
7137410
to
1892bf7
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @janekmi)
a discussion (no related file):
Previously, janekmi (Jan Michalski) wrote…
Please also change the commit message:
common: print a message in case pmem won't be able to be used
Done.
a discussion (no related file):
Previously, janekmi (Jan Michalski) wrote…
Please fix the commit message. It is important for Gihub to track relationships between PRs and PRs and issues.
Ref: #1089Note:
#is crucial.Refis for the human reader.Ref: https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls (please read)
Done.
CMakeLists.txt, line 108 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
After reconsideration, I recommend a small change:
Since libpmem is missing, the examples will be...
Sorry. ;-)
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Patryk717)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Patryk717)
a discussion (no related file):
Please rebase on upstream/master. You have something messed up a bit. ;-)
Patryk717
force-pushed
the
all_examples
branch
from
1892bf7
to
1ce4913
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
Previously, janekmi (Jan Michalski) wrote…
Please rebase on upstream/master. You have something messed up a bit. ;-)
done
There was a problem hiding this comment.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Ref: #1089
This change is