Bug in Differentiable Tpfa related to fracture tips and internal boundaries #1111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The previous implementation of differentiable Tpfa contained a bug which gave non-zero transmissibilities on fracture tips and internal boundaries (where the transmissibilities should be zero, but were not). This PR introduces a fix which by filtering sets the transmissibilites to zero at the relevant faces.
A similar fix was also introduced for the potential_trace function, but this is only relevant for the fracture tips.
A new test that covers the fixed code has been added.
Resolves #1104
Resolves #1107
Resolves #1108
Types of changes
What types of changes does this PR introduce to PorePy?
Put an
x
in the boxes that apply.Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.