Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Differentiable Tpfa related to fracture tips and internal boundaries #1111

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

keileg
Copy link
Contributor

@keileg keileg commented Jan 24, 2024

Proposed changes

The previous implementation of differentiable Tpfa contained a bug which gave non-zero transmissibilities on fracture tips and internal boundaries (where the transmissibilities should be zero, but were not). This PR introduces a fix which by filtering sets the transmissibilites to zero at the relevant faces.

A similar fix was also introduced for the potential_trace function, but this is only relevant for the fracture tips.

A new test that covers the fixed code has been added.

Resolves #1104
Resolves #1107
Resolves #1108

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

An error gave a non-zero transmissibility on those faces.
This commit removes that error and introduces a test for this case.
Copy link
Contributor

@IvarStefansson IvarStefansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One bugfix (pushed) and one substantial question.

tests/models/test_thermoporomechanics.py Show resolved Hide resolved
@keileg keileg merged commit b91ef05 into develop Jan 26, 2024
4 checks passed
@keileg keileg deleted the issue_1104 branch January 26, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name mistake in test function Name mistake in test function Bug in AdTpfaFlux
2 participants