New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dfn transport #219
Dfn transport #219
Conversation
…arcy and then a advection+diffusion with tpfa and upwind
…ue. for method mvem/rt0
…ect_plane_matrix and project_line_matrix
… a possible publication
…new implementation,
…consistent way among examples
…wer dimensional objects
Conflicts: src/porepy/numerics/interface_laws/elliptic_interface_laws.py
@@ -10,7 +10,7 @@ | |||
import scipy.sparse as sps | |||
|
|||
|
|||
class EmptyDiscretization(object): | |||
class Cell_dof_face_dof_map(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation update needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean?
@IvarStefansson , should I raise an error for extract_flux? OK for the documentation of Cell_dof_face_dof_map |
…tion of the heat equation
…andle only scalar source term in primal formulation (currently tpfa, mpfa)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am mostly happy; the only substantial change is the naming of the tolerance in mpfa/vem/rt0 (should also be tpfa?).
if g_master.dim == g_slave.dim: | ||
self.discr_slave.enforce_neumann_int_bound( | ||
g_slave, data_edge, matrix, True, slave_ind | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The finite volume schemes does not use the enforce_neumann_int_bound, but my guess is that the first is correct. Otherwise are you will try to enforce Neumann conditions on the cells of the lower dim grid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I should reverse the change to the original one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
if g_master.dim == g_slave.dim: | ||
self.discr_slave.enforce_neumann_int_bound( | ||
g_slave, data_edge, matrix, True, slave_ind | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The finite volume schemes does not use the enforce_neumann_int_bound, but my guess is that the first is correct. Otherwise are you will try to enforce Neumann conditions on the cells of the lower dim grid?
some updates mainly related to the dfn upscaling paper. there are few fixing of the code, so very useful. please consider a deep check mainly on that parts. the branch might not be 100% finished, but 99%.