Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linking libtensorflow_framework under tensorflow 1.14 #32

Closed
pmh47 opened this issue Jun 30, 2019 · 0 comments
Closed

Fix linking libtensorflow_framework under tensorflow 1.14 #32

pmh47 opened this issue Jun 30, 2019 · 0 comments

Comments

@pmh47
Copy link
Owner

pmh47 commented Jun 30, 2019

libtensorflow_framework.so has become libtensorflow_framework.so.1 as of tensorflow 1.14, hence it is not found by cmake. The best way to fix this is to change tf.sysconfig.get_lib to tf.sysconfig.get_link_flags, which in turn requires bumping our minimum supported tensorflow version to 1.5, when that function was added.
@pmh47 pmh47 mentioned this issue Jun 30, 2019
Closed
pmh47 added a commit that referenced this issue Jul 1, 2019
@pmh47
Updates to support Tensorflow 1.14 (#30 and #32)
6bb58fc 
- fixing include paths and symbol name for cuda helpers, following
changes to tensorflow
- changing get_lib to get_link_flags, to allow finding renamed
libtensorflow_framework.so.1
- bumping required tensorflow version to 1.6 (for the updated header
names; 1.5 is required for get_link_flags)
@pmh47 pmh47 closed this as completed Jul 1, 2019
@vineethbabu vineethbabu mentioned this issue Sep 12, 2019
Closed
SimonSelg added a commit to SimonSelg/lmbspecialops that referenced this issue Feb 2, 2020
@SimonSelg
add support for tensorflow >= 1.14
e2122cb 
in tensorflow 1.14, libtensorflow_framework.so was renamed to libtensorflow_framework.so.1
this broke the cmake build. we now use  to return the linker flags.
this bumps the minimum version to 1.15 (where  was introduced)

see pmh47/dirt#32 for the same issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmh47