Tool Connection to PMIx Server #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhc54
force-pushed
the
topic/tools
branch
2 times, most recently
from
dd25523
to
6ad70ae
Compare
rhc54
force-pushed
the
topic/tools
branch
4 times, most recently
from
f355809
to
33d6365
Compare
| tl -> address.sun_family = AF_UNIX; | ||
| tl->protocol = PMIX_PROTOCOL_TOOL; | ||
| /* Get up to 10 chars of hostname.*/ | ||
| gethostname(myhostname, myhostnamelen); |
There was a problem hiding this comment.
@rhc54 you need this inline patch
diff --git a/opal/mca/pmix/pmix2x/pmix/src/server/pmix_server.c b/opal/mca/pmix/pmix2x/pmix/src/server/pmix_server.c
index 0533b38..18ac503 100644
--- a/opal/mca/pmix/pmix2x/pmix/src/server/pmix_server.c
+++ b/opal/mca/pmix/pmix2x/pmix/src/server/pmix_server.c
@@ -227,7 +227,7 @@ PMIX_EXPORT pmix_status_t PMIx_server_init(pmix_server_module_t *module,
size_t n, m;
pmix_kval_t kv;
pmix_listener_t *lt;
- int myhostnamelen = 10;
+ int myhostnamelen = 11;
char myhostname[myhostnamelen];
char *pmix_pid, *tdir;
char **protected = NULL;
@@ -293,6 +293,10 @@ PMIX_EXPORT pmix_status_t PMIx_server_init(pmix_server_module_t *module,
tl->protocol = PMIX_PROTOCOL_TOOL;
/* Get up to 10 chars of hostname.*/
gethostname(myhostname, myhostnamelen);
+ /* gethostname might not null terminate myhostname
+ * if hostname size is greater than myhostnamelen,
+ * so do it ourself */
+ myhostname[10] = '\0';
/* need to put this in the global tmpdir as opposed to
* where the server tmpdir might be */
if (NULL == (tdir = getenv("TMPDIR"))) {otherwise i get some random hangs on my centos 7 box with a long hostname
|
this pr should be rebased because of the conflict caused by #112 |
|
working on it... |
* creating a separate Unix domain socket for tool/PMIx server rendezvous
in a location both agree upon. The system will automatically look for
the rendezvous file in a standard tmp directory using the format of
"TMPDIR/pmix.hostname.pid". If only one is found, then that is used.
If multiple are found and no directive was given as to which pid to
use, then an error is returned. If a directive is given, then only
that pid is searched for and an error returned if not found.
* defining a new "pmix_tool.h" header that solely contains two APIs:
* PMIx_Tool_init - initializes the connection to the local PMIx server
* PMIx_Tool_finalize - closes the connection
* adds new PMIx_Query_info[_nb] APIs by which the tool can request
info from the RM via the local PMIx server
The commit includes a unit test simple/simptool that exercises the
new functionality, and an example program
Modify the configure code so we have the option of installing the pmix library without the tests and examples
Remove stale header reference
Resolve merge conflicts with master
Cleanups from Coverity
Fix Coverity warning
Allow longer hostname lengths, ensure they are NULL terminated
Provide the host RM with the uid and gid of the connecting tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs pmix/RFCs#1