Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch. 1: Issue 175: Separate out the PMIx client interface from the CL/host interactions #192

Merged
merged 15 commits into from
Jul 23, 2020

Conversation

dsolt
Copy link
Contributor

@dsolt dsolt commented Jun 4, 2019

…y searching

@dsolt dsolt added the WorkInProgress Work In Progress label Jun 4, 2019
@dsolt dsolt changed the title Capture notes taken during WG meetings with the tag ISSUE175: for eas… Issue 175: Separate out the PMIx client interface from the CL/host interactions Jun 4, 2019
@jjhursey
Copy link
Member

jjhursey commented Jun 7, 2019

Ref Issue #175

@dsolt dsolt force-pushed the issue_175_chapter_1 branch 3 times, most recently from 91a7b95 to 8f2f061 Compare August 27, 2019 17:47
Chap_Introduction.tex Outdated Show resolved Hide resolved
Chap_Introduction.tex Outdated Show resolved Hide resolved
@jjhursey
Copy link
Member

@dsolt I have a couple of inline fixes for a section header and ac expansion above that I didn't see reflected in the current version of the document.

Chap_Introduction.tex Outdated Show resolved Hide resolved
@jjhursey
Copy link
Member

We had a few notes from the Q4 2019 meeting for this document that we should make sure are reviewed:

Copy link
Contributor

@SteVwonder SteVwonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two questions below.

Chap_Introduction.tex Outdated Show resolved Hide resolved
Chap_Introduction.tex Outdated Show resolved Hide resolved
@dsolt dsolt added Eligible Eligible for consideration by ASC and removed WorkInProgress Work In Progress labels Dec 21, 2019
dsolt and others added 13 commits December 21, 2019 12:59
Signed-off-by: David Solt dsolt@us.ibm.com
Signed-off-by: David Solt dsolt@us.ibm.com
Signed-off-by: David Solt dsolt@us.ibm.com
Signed-off-by: David Solt dsolt@us.ibm.com
Signed-off-by: David Solt dsolt@us.ibm.com
…planation of why support may vary

Signed-off-by: David Solt dsolt@us.ibm.com
Signed-off-by: David Solt dsolt@us.ibm.com
…ributes

Signed-off-by: David Solt dsolt@us.ibm.com
Co-Authored-By: Josh Hursey <4259120+jjhursey@users.noreply.github.com>
Signed-off-by: David Solt dsolt@us.ibm.com
Signed-off-by: David Solt dsolt@us.ibm.com
Signed-off-by: David Solt dsolt@us.ibm.com
Signed-off-by: David Solt dsolt@us.ibm.com
…tes)

Signed-off-by: David Solt dsolt@us.ibm.com
@dsolt
Copy link
Contributor Author

dsolt commented Jan 23, 2020

@jjhursey
Copy link
Member

PMIx ASC Q1'2020 Meeting:

  • The reading generally went well. A number of changes which were mostly minor in nature were recommended. A couple of recommendations could become significant in size/implications depending on how the working group handles them. As such, the group decided to neither officially push back nor vote on this proposal in this meeting.
  • The group suggested the following:
    • The working group should apply the recommended changes to Chapter 1
    • Post a new version of the document to this PR with a reference to the commit(s) in which they were implemented.
    • Post a new straw poll on this PR with a note to the mailing list.
    • ASC members will vote in the straw poll and note in the comments if they wish to have a full formal reading in the next meeting. Lack of such a comment will indicate that the changes were minor enough to not warrant a full reading.
    • If a full reading is requested then it will be scheduled in the next meeting with a possible first formal vote immediately afterward.
    • If a full reading is not requested then a summary reading of the changes will be presented in the next meeting followed by the first vote.

A summary of the recommended changes are indicated in the notes from the ASC meeting.

Chap_Introduction.tex Outdated Show resolved Hide resolved
Chap_Introduction.tex Outdated Show resolved Hide resolved
Chap_Introduction.tex Outdated Show resolved Hide resolved
Chap_Introduction.tex Outdated Show resolved Hide resolved
Chap_Introduction.tex Outdated Show resolved Hide resolved
Signed-off-by: David Solt dsolt@us.ibm.com
@dsolt
Copy link
Contributor Author

dsolt commented Feb 13, 2020

We would like feedback on whether the changes in the last commit are sufficiently trivial to avoid a moving this ticket back to a first reading. If you are ok with us moving this forward to a 2nd reading please emoji a thumbs up. If you prefer that the working group represent this as a first reading because you feel the changes are significant, please emoji a thumbs down.

Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.

  • You do not need to vote on every proposal
  • If you have no opinion, don't vote - that is also useful data
  • If you've already commented on this issue, please still vote so

@jjhursey jjhursey changed the title Issue 175: Separate out the PMIx client interface from the CL/host interactions Ch. 1: Issue 175: Separate out the PMIx client interface from the CL/host interactions Mar 19, 2020
local \ac{PMIx} server, which subsequently might request services from the host \ac{SMS}
(represented here by a \ac{RM} daemon).
The interaction between the \ac{PMIx} server and \ac{SMS} are
achieved using callback functions registered during server initialization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An SMS may choose to completely embed the PMIx server; thus not needing the PMIx server API.

Maybe different wording would work better;

Suggested change
achieved using callback functions registered during server initialization.
To facilitate the interaction between the \ac{PMIx} server and the \ac{SMS}, the \ac{PMIx} server API provides callback functions to be registered during server initialization.

Chap_Introduction.tex Show resolved Hide resolved
@jjhursey jjhursey mentioned this pull request Apr 15, 2020
@jjhursey
Copy link
Member

PMIx ASC 2Q 2020 Meeting:

  • Passed first vote: 10 Yes / 0 No / 0 Abstain / 4 not present for vote
  • Discussion point here will be resolved in a separate, following PR.

@rhc54
Copy link
Member

rhc54 commented Jun 23, 2020

Given the status of this PR and that I will need to modify Chapter 1 to update the history for release of v4, I would like to commit this into the master branch. Can we discuss and perhaps get agreement to do so at the July meeting given that there doesn't appear to be any opposition?

@jjhursey
Copy link
Member

PMIx ASC 3Q 2020 Meeting:

  • Passed Second Vote 8 Yes / 0 No / 2 Abstain / 4 not present for vote
  • The ASC also discussed including this in the v4 release and had no objection in doing so. So we will merge this into master and it will be included in the v4 and future releases.

Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jjhursey jjhursey added the Accepted as Stable ASC second vote passed. Accepted as Stable! label Jul 23, 2020
@jjhursey jjhursey merged commit 1fc092e into pmix:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted as Stable ASC second vote passed. Accepted as Stable! Eligible Eligible for consideration by ASC First Vote Passed ASC first vote passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants