Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup Python bindings to match C bindings #314

Merged
merged 2 commits into from Dec 12, 2020
Merged

Conversation

jjhursey
Copy link
Member

  • Fixes Review Python Bindings #313
  • Adds the following:
    • PMIx_Parse_cpuset_string
    • PMIx_server_generate_locality_string
    • PMIx_server_generate_cpuset_string
  • Fix cross-references of APIs to point to their blocking counterpart (instead of the nonblocking counterpart) for consistency.
  • Fix cross-references of callbacks to their C counterparts
  • Fix name of PMIx_Allocation_request Python binding from allocate to allocation_request
  • Fix arguments passed to Tool.set_server

Signed-off-by: Joshua Hursey jhursey@us.ibm.com

 * Adds the following:
   - `PMIx_Parse_cpuset_string`
   - `PMIx_server_generate_locality_string`
   - `PMIx_server_generate_cpuset_string`
 * Fix cross-references of APIs to point to their blocking counterpart (instead of the nonblocking counterpart) for consistency.
 * Fix cross-references of callbacks to their C counterparts
 * Fix name of PMIx_Allocation_request Python binding from allocate to allocation_request
 * Fix arguments passed to Tool.set_server

Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey jjhursey added this to the PMIx v4 Standard milestone Dec 11, 2020
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey jjhursey removed the WorkInProgress Work In Progress label Dec 12, 2020
@jjhursey jjhursey marked this pull request as ready for review December 12, 2020 02:22
@jjhursey jjhursey requested a review from rhc54 December 12, 2020 02:22
@jjhursey jjhursey mentioned this pull request Dec 12, 2020
28 tasks
Copy link
Member

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh!

@rhc54 rhc54 changed the title Fixup Python bindinds to match C bindings Fixup Python bindings to match C bindings Dec 12, 2020
@rhc54 rhc54 merged commit 953dec1 into pmix:master Dec 12, 2020
@jjhursey jjhursey deleted the fixup-py branch December 14, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Python Bindings
2 participants