Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Travis to GitHub Actions #340

Merged
merged 1 commit into from Mar 8, 2021
Merged

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Mar 2, 2021

  • Due to rate limiting restrictions in Travis, move to GitHub Actions

@jjhursey
Copy link
Member Author

jjhursey commented Mar 2, 2021

To see what this looks like click on the Checks tab in the PR below:

Apparently, GitHub made an agreement with DockerHub that avoids the rate limit issue. Even if they hadn't we could add an authentication token to the Action to work around it. So far this looks like it is working.

@jjhursey jjhursey requested a review from a team March 2, 2021 20:47
Copy link
Contributor

@SteVwonder SteVwonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjhursey for putting this together! Good to know that Github Actions are exempt from docker hub pulls.

.github/workflows/build-ci.yml Show resolved Hide resolved
uses: actions/checkout@v1
# Run the container tester
- name: Build and Test
run: docker run --rm -v ${GITHUB_WORKSPACE}:/home/pmixer/pmix-standard jjhursey/pmix-standard /bin/bash -c "cp -R /home/pmixer/pmix-standard pmix-build && cd pmix-build && make"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and created the pmix organization on docker hub (and added you @jjhursey as an owner) if we eventually want to switch to that top-level namespace:

Suggested change
run: docker run --rm -v ${GITHUB_WORKSPACE}:/home/pmixer/pmix-standard jjhursey/pmix-standard /bin/bash -c "cp -R /home/pmixer/pmix-standard pmix-build && cd pmix-build && make"
run: docker run --rm -v ${GITHUB_WORKSPACE}:/home/pmixer/pmix-standard pmix/pmix-standard /bin/bash -c "cp -R /home/pmixer/pmix-standard pmix-build && cd pmix-build && make"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting that up. I was thinking of moving those github repos into the pmix or openpmix GitHub namespace anyway, so it would make sense to rename the container namespace at the same time. I'll put that on my near-ish term todo list. We can make this change once that is moved over.

 * Due to rate limiting restrictions in Travis, move to GitHub Actions

Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey
Copy link
Member Author

jjhursey commented Mar 8, 2021

@SteVwonder can you give a final review so we can merge?
I'll work on moving those containers in the next few weeks. We can update the GH Action once that's done.

Copy link
Contributor

@SteVwonder SteVwonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jjhursey jjhursey merged commit f348cdd into pmix:master Mar 8, 2021
@jjhursey jjhursey deleted the gh-actions branch March 8, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants