New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for 7.3.0beta #14

Closed

remicollet wants to merge 1 commit into pmjones:master from remicollet:issue-php73b

Contributor

remicollet commented Aug 16, 2018

php_setcookie API have changed

-PHPAPI int php_setcookie(zend_string *name, zend_string *value, time_t expires, zend_string *path, zend_string *domain, int secure, int url_encode, int httponly);
+PHPAPI int php_setcookie(zend_string *name, zend_string *value, time_t expires, zend_string *path, zend_string *domain, int secure, int httponly, zend_string *samesite, int url_encode);


          fix for 7.3.0beta

96477c1

coveralls commented Aug 16, 2018

Coverage decreased (-0.02%) to 92.739% when pulling 96477c1 on remicollet:issue-php73b into 86a5b2b on pmjones:master.

pmjones closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment