This repository has been archived by the owner on May 9, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Logger log levels are off: please fix them or make them customizable #139
Comments
I do like the protected override method approach, can you make a PR? :) |
Here you go: #140 |
pmlopes
added a commit
that referenced
this issue
Oct 18, 2014
#139 extracted message logging into protected method
Cool, thanks! |
Any hope to have this in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently the
Logger
middleware uses the following mapping:This is problematic when you use a monitoring system that inspects log lines because client errors (4xx) are reported at the
ERROR
level, which is typically the level at which server errors are logged. This leads to a mix of genuine server side errors and client side errors.Moreover 3x responses are perfectly fine, there's no reason to log them at
WARN
level.So IMO the "correct" mapping should be:
I can totally understand that you may not want to change the existing implementation so could you make it possible to alter the the current behaviour either by:
protected
method that a sub-class can implement differently,Thank you for considering this 😸
The text was updated successfully, but these errors were encountered: