Skip to content
This repository has been archived by the owner on May 9, 2019. It is now read-only.

Created simple CORS middleware #117

Merged
merged 2 commits into from Jul 26, 2014
Merged

Created simple CORS middleware #117

merged 2 commits into from Jul 26, 2014

Conversation

ddossot
Copy link
Contributor

@ddossot ddossot commented Jul 25, 2014

No description provided.

pmlopes added a commit that referenced this pull request Jul 26, 2014
Created simple CORS middleware
@pmlopes pmlopes merged commit 3bacbe1 into pmlopes:develop Jul 26, 2014
@pmlopes
Copy link
Owner

pmlopes commented Jul 26, 2014

Thanks! I will merge on extras, once there is some documentation and I do some review, if there are no external dependencies on libraries I will consider merging to the main framework!

Thanks!

@purplefox
Copy link

David,

I would like to have CORS handling in Apex https://github.com/vert-x3/vertx-apex/tree/initial-work - would you be ok with contributing to that?

@ddossot
Copy link
Contributor Author

ddossot commented Dec 1, 2014

@purplefox I would love to, only thing is that December is pretty busy so things may not move much until next year.

Also any contributor agreement and coding guidelines (style, formatting) you can point me to?

@purplefox
Copy link

No problem. If you are busy then I am happy to port it myself, but would need your permission to contribute it. I.e. sign the CLA :)

CLA is just the standard Eclipse one.

@ddossot
Copy link
Contributor Author

ddossot commented Dec 1, 2014

I've already signed the Eclipse CLA: https://projects.eclipse.org/users/ddossot/cla (screenshot).

One thing to note: this implementation I've contributed to Yoke does not support the optional Access-Control-Max-Age feature, which you may want to add for the sake of completeness in your port. See this great flowchart for details.

@purplefox
Copy link

Great, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants