Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack 5 with browserslist config breaks react-refresh plugin #235

Closed
bentrynning opened this issue Oct 26, 2020 · 3 comments · Fixed by #283
Closed

Webpack 5 with browserslist config breaks react-refresh plugin #235

bentrynning opened this issue Oct 26, 2020 · 3 comments · Fixed by #283

Comments

@bentrynning
Copy link

bentrynning commented Oct 26, 2020 •
edited

Versions
"webpack": "5.1.3",
"webpack-cli": "4.1.0",
"webpack-dev-server": "3.11.0"
"@pmmmwh/react-refresh-webpack-plugin": "0.4.2"
"react-refresh": "0.9.0",

Since updateing to webpack 5 react-refresh plugin stops working. Looks like it has something to to with the target in webpack being set to target: browserslist when browserslist config is present in repository. This is new in webpack 5

It can be reproduced by ether adding .browserlistrc or browserslist to package.json

I could be that this is some issue with react-refresh, but ill try my luck here first :)

Workaround is to explicit set target: 'web' when in development in webpack config.
Test repo: https://github.com/bentrynning/react-refresh
@anajavi
Copy link

anajavi commented Oct 28, 2020

This seems to be related:
webpack/webpack-dev-server#2758

@pmmmwh
Copy link
Owner

pmmmwh commented Nov 1, 2020

This is unfortunately a problem from upstream - no code in the plugin is specific for the web and would stay that way.

hyochan added a commit to dooboolab-community/dooboo-frontend-ts that referenced this issue Nov 3, 2020
@hyochan
Add target web to webpack for HMR
8a98ea9 
Related pmmmwh/react-refresh-webpack-plugin#235
@hyochan hyochan mentioned this issue Nov 3, 2020
Merged
hyochan added a commit to dooboolab-community/dooboo-frontend-ts that referenced this issue Nov 3, 2020
@hyochan
Update packages and migrate to webpack 5 (#82)
d07cbb8 
Update packages and migrate to webpack5. We had an issue in react-fast-refresh on webpack5 but could resolve this issue with the workaround given in pmmmwh/react-refresh-webpack-plugin#235.
@twgraham twgraham mentioned this issue Nov 12, 2020
Closed
@pmmmwh
Copy link
Owner

pmmmwh commented Nov 30, 2020

This have been resolved in webpack-dev-server@4.0.0-beta.0

@pmmmwh pmmmwh closed this as completed Nov 30, 2020
@pmmmwh pmmmwh mentioned this issue Dec 24, 2020
Merged
@momesana momesana mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add a note on wds v3 and webpack 5 browserslist pmmmwh/react-refresh-webpack-plugin
3 participants
@anajavi @bentrynning @pmmmwh