Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webpack 5 support #123

Merged
merged 25 commits into from
Jun 23, 2020
Merged

feat: add webpack 5 support #123

merged 25 commits into from
Jun 23, 2020

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented Jun 20, 2020

This PR adds support for Webpack 5 beta using latest features like runtime modules and module execution interceptors. Most sharable code is being refactored into a generic utils directory and some code cleanup was also done.

Currently this will need 5.0.0-beta.18 as a minimum version because there was a bug in the HMR runtime in older versions. There's also an outstanding bug (which will be fixed by webpack/webpack#11059) that I had to workaround.

Fixes #27
Fixes #119

@pmmmwh pmmmwh added the enhancement New feature or request label Jun 20, 2020
@pmmmwh pmmmwh self-assigned this Jun 20, 2020
@pmmmwh pmmmwh force-pushed the feat/webpack-5 branch 2 times, most recently from eaa9bc5 to d0f4cd4 Compare June 21, 2020 09:56
@pmmmwh pmmmwh merged commit 5b7e394 into main Jun 23, 2020
@pmmmwh pmmmwh deleted the feat/webpack-5 branch June 23, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using some options for Webpack will cause plugin to crash build Issues with Webpack 5
1 participant