fix: remove addDependency and only require RefreshModuleRuntime once #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronSean
reviewed
Dec 13, 2019
src/loader.js
Outdated
| const { Template } = require('webpack'); | ||
| const { refreshUtils } = require('./runtime/globals'); | ||
| const RefreshModuleRuntime = require('./runtime/RefreshModuleRuntime'); | ||
| const RefreshModuleRuntimeString = Template.getFunctionContent(RefreshModuleRuntime); |
There was a problem hiding this comment.
I thought there was already a comment here about this, but if this line is safe to remove from the function, is there any reason the trim() or the replace calls can't also be brought out and only run once?
|
This makes sense to me |
pmmmwh
approved these changes
Dec 17, 2019
|
Thanks a lot for this - I can confirm it brings huge performance improvements to large projects I'm working on. |
pmmmwh
changed the title
pmmmwh
changed the title
|
Shipped in |
|
Awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the require for the
RefreshModuleRuntimeoutside of the loader function and removed thethis.addDependencycall, which seemed to be invalidating caching webpack was doing. This fixes incremental recompile performance in the fairly large project I'm working in. It's also noticeable in the example app wds project (although the recompiles are already really fast 😁):Pre
Post
Fixes #20