ci: fix test failures #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmmmwh
force-pushed
the
ci/fix-failures
branch
from
6719696
to
a08f30b
Compare
|
Scheduled publish of new batch of fixed image at 00:00 UTC - Blocked until that happens and all tests are re-triggered. |
|
One last remaining issue is on swapping Webpack versions within a |
|
Tests now run properly on both Webpack 4 and 5 - and for Webpack 5 they are failing correctly since we haven't caught up to all latest changes from webpack 5.0 to 5.4 ... |
|
Tests should pass now 🤞🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Chromium for CI - sandboxing is now disabled due to difficulty to have it working reliably (If we had the option to run Docker with more privileges it would work but not at the moment).This PR fixes multiple stuff for CI:
cimg-puppeteerunder the hood nowwebpack@latestand also the corresponding CLI to latest versions