Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-peer): relax peer dependency on type-fest #257

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented Nov 18, 2020

This fixes #244

@pmmmwh pmmmwh added the dependencies Pull requests that update a dependency file label Nov 18, 2020
@pmmmwh pmmmwh self-assigned this Nov 18, 2020
@pmmmwh pmmmwh merged commit e9ff50e into main Nov 18, 2020
@pmmmwh pmmmwh deleted the fix/type-fest-deps branch November 18, 2020 14:26
@tessro
Copy link

tessro commented Feb 3, 2021

Hi! Any chance of a release including this change? npm 7 went GA today, and the new peerDependencies resolution makes this PR extra helpful! 🤞🏼

@pmmmwh
Copy link
Owner Author

pmmmwh commented Feb 8, 2021

Hi, this is already in the latest beta. Unfortunately I have been really busy lately, hopefully the next release can come out in a week or two.

@dflynn15
Copy link

dflynn15 commented Mar 9, 2021

Thanks for doing this in beta! Could there also be a patch version for 0.4.3 -> 0.4.4 that also relaxes the peer dependency?

@pmmmwh
Copy link
Owner Author

pmmmwh commented Mar 9, 2021

Hi - I'm not planning to back port this since the stable release for 0.5.x will be here soon (only outstanding task is ESM-related stuff which I'm actively working on). There are no breaking changes in the API so upgrading should be easy.

@kenziebottoms
Copy link

Any updates on either a patch version or 0.5.x?

@pmmmwh
Copy link
Owner Author

pmmmwh commented Jun 20, 2021

Any updates on either a patch version or 0.5.x?

The RC (0.5.0-rc.0) is already here, which is stable.

@aarowman
Copy link

When will 0.5.x be officially released? I am still getting the error from react-scripts from issue #244 because react-scripts still uses 0.4.x

@pmmmwh
Copy link
Owner Author

pmmmwh commented Aug 29, 2021

When will 0.5.x be officially released? I am still getting the error from react-scripts from issue #244 because react-scripts still uses 0.4.x

CRA v5 will be using 0.5.x. For now, I do not have a concrete release date when 0.5.x will be stable - I'm working on patching all the known bugs and release it, but all the remaining ones are quite tricky, but I still hope to release this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type-fest peer dependency warning
5 participants