Fix CRA error overlay clashing with fast-refresh overlay #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #7
The 2 error overlays were clashing. What I've done is
src
directory of the this package.Additionally I've added a README section on setting up this project with
create-react-app
in addition to the other setup instructions.Expected
If you clone the repo, run the CRA example, then create some import/syntax error
Unresolved in this PR
webpack@4.41.5
, but this repo doesn't have any top-level lockfile and as a result brings in a different, newer version of webpack. Actually resolving this in a robust way would likely require some type of monorepo tooling to make the examples separate private packages with their own independant dependency tree. In the meantime, I added an.env
file to bypass this check.Module not found: You attempted to import /Users/adamcharron/git/react-refresh-webpack-plugin/src/runtime/utils.js which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.