Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feature detect Webpack compiler version #415

Merged
merged 8 commits into from
Jun 3, 2021
Merged

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented May 31, 2021

This moves all code paths that call Webpack to use the compiler.webpack shorthand when possible, and fallback to an inlined require to Webpack, so repositories with multiple installed versions of Webpack (plus potential hoisting) could actually infer the version of Webpack correctly from the current running compiler.

Fixes #247
Fixes #308

@pmmmwh
Copy link
Owner Author

pmmmwh commented Jun 1, 2021

TODO: Migrate loader to use this._compiler.webpack also?

@pmmmwh pmmmwh merged commit a88fd0f into main Jun 3, 2021
@pmmmwh pmmmwh deleted the feat/feature-detection branch June 3, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant