Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom sockHost/sockPort/sockPath #52

Merged
merged 4 commits into from
Apr 1, 2020

Conversation

marcello3d
Copy link
Contributor

Add sockHost and sockPort option so that react-refresh-webpack-plugin can be configured to work through a proxy.

Tested using patch-package.

Fixes #40

@pmmmwh
Copy link
Owner

pmmmwh commented Mar 29, 2020

Hey - thanks for this PR! Can you also add handling for sockPath?

Also - is it possible for you to fix the merge conflicts (or give me access to your repo so I can push changes there)?

@marcello3d
Copy link
Contributor Author

Merged the basic conflicts, but need to update the README and verify that it still works.

@marcello3d marcello3d changed the title Add custom sockHost/sockPort Add custom sockHost/sockPort/sockPath Mar 31, 2020
@marcello3d
Copy link
Contributor Author

@pmmmwh I fixed up this branch and did more testing. It seems to work OK, but I've noticed that after the error overlay pops up from a build error, it never goes away until I reload the page (even if I get a subsequent successful build).

@pmmmwh pmmmwh self-requested a review April 1, 2020 19:41
@pmmmwh pmmmwh self-assigned this Apr 1, 2020
@pmmmwh pmmmwh added the enhancement New feature or request label Apr 1, 2020
@pmmmwh
Copy link
Owner

pmmmwh commented Apr 1, 2020

@pmmmwh I fixed up this branch and did more testing. It seems to work OK, but I've noticed that after the error overlay pops up from a build error, it never goes away until I reload the page (even if I get a subsequent successful build).

I've checked - that is related to another issue. I will merge this first because what I'm working on depends on this, and I will fix that issue in another PR.

@pmmmwh pmmmwh merged commit e27abff into pmmmwh:master Apr 1, 2020
@pmmmwh pmmmwh deleted the add-custom-port-host branch April 1, 2020 19:45
@pmmmwh
Copy link
Owner

pmmmwh commented Apr 1, 2020

it never goes away until I reload the page (even if I get a subsequent successful build).

Fixed in #57

@marcello3d
Copy link
Contributor Author

@pmmmwh sweet! are either of these fixes on NPM at this point? I see a 0.3.0-beta.0 release but not sure what's in that

@pmmmwh
Copy link
Owner

pmmmwh commented Apr 1, 2020

@pmmmwh sweet! are either of these fixes on NPM at this point? I see a 0.3.0-beta.0 release but not sure what's in that

Not yet, but beta 1 will contain them. I'll publish when I'm done with some other fixes.

@pmmmwh
Copy link
Owner

pmmmwh commented Apr 1, 2020

Released in 0.3.0-beta.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom ports for websockets
2 participants