Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid command parameter types #62

Closed
tobiaskirchmaier opened this issue Apr 22, 2022 · 3 comments
Closed

Invalid command parameter types #62

tobiaskirchmaier opened this issue Apr 22, 2022 · 3 comments

Comments

@tobiaskirchmaier
Copy link

Some parameter types in AvailableCommandsPacket have changed with the update 1.18.30 and are now invalid.


ARG_TYPE_WILDCARD_TARGET = 0x08 -> ARG_TYPE_WILDCARD_TARGET = 0x09
ARG_TYPE_STRING = 0x20 -> ARG_TYPE_STRING = 0x26
ARG_TYPE_POSITION = 0x28 -> ARG_TYPE_POSITION = 0x2F
ARG_TYPE_MESSAGE = 0x2c -> ARG_TYPE_MESSAGE = 0x32
ARG_TYPE_RAWTEXT = 0x2e -> ARG_TYPE_RAWTEXT = 0x34
ARG_TYPE_JSON = 0x32 -> ARG_TYPE_JSON = 0x38
ARG_TYPE_COMMAND = 0x3f -> ARG_TYPE_COMMAND = 0x45

and

ARG_TYPE_BLOCK_POSITION = 0x2E

This fact was not tested in detail!

@jasonw4331
Copy link

Relates to #60

@sky-min
Copy link
Contributor

sky-min commented Apr 22, 2022

Oh, I thought ARG_TYPE_WILDCARD.Destination was deleted but changed.

@dktapps
Copy link
Member

dktapps commented Apr 23, 2022

Fixed by 9d3cc87.

@dktapps dktapps closed this as completed Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants