Command Parmeter change for 1.18.30 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonw4331
approved these changes
Apr 21, 2022
dktapps
reviewed
Apr 23, 2022
src/AvailableCommandsPacket.php
Outdated
|
|
||
| public const ARG_TYPE_FILEPATH = 0x10; | ||
|
|
||
| public const ARG_TYPE_STRING = 0x20; | ||
| public const ARG_TYPE_POSITION = 0x20; |
There was a problem hiding this comment.
From my analysis this appears incorrect. There is no symbol associated with 0x20.
I see two possible values for position 0x2e and 0x2f. I don't know why there are 2 or what the difference between them is.
There was a problem hiding this comment.
2e appears to be block position, while 2f appears to be any floating-point vector position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were found in 1.18.30.
NeroLuna helped me find it!