Facing and Axis to enum #91
Open
+113
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
reviewed
Nov 19, 2023
dktapps
reviewed
Nov 20, 2023
|
If we're going with enums I would prefer to ditch the numeric values entirely. They have no purpose except to be implicitly misused as Minecraft constants. |
Should I do the same for Axis? I don't know if these values represent anything or not |
Yes |
dktapps
reviewed
Nov 21, 2023
dktapps
reviewed
Nov 21, 2023
dktapps
reviewed
Nov 21, 2023
dktapps
reviewed
Nov 21, 2023
dktapps
reviewed
Nov 21, 2023
dktapps
reviewed
Nov 21, 2023
dktapps
reviewed
Nov 21, 2023
Dhaiven
commented
Nov 27, 2023
|
This pr is good ? if yes i can change pocketmine to support Facing enum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #89
This change requires many changes in pmmp. I can do if this pr is good for you.