Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is "server-name" option affect on something? #1944

Closed
Yexeed opened this issue Jan 20, 2018 · 3 comments
Closed

Is "server-name" option affect on something? #1944

Yexeed opened this issue Jan 20, 2018 · 3 comments
Labels
Resolution: Invalid

Comments

@Yexeed
Copy link

Yexeed commented Jan 20, 2018

Issue description

  • Expected result: "server-name" affects on something.
  • Actual result: "server-name" field wasnt found in Server.php class and it doesnt affect something.

I dont think that any description needed. I just saw that on Nukkit "server-name" affects on this field:
image
But on PMMP it doesn't
@Yexeed
Copy link
Author

Yexeed commented Jan 20, 2018 •
edited

Someone can say that "server-name" doesn't provided by server generator by default:
image
But SetupWizard does
image

@dktapps
Copy link
Member

dktapps commented Jan 20, 2018

Legacy code. That property is deprecated.

@dktapps dktapps closed this as completed Jan 20, 2018
@Yexeed
Copy link
Author

Yexeed commented Jan 20, 2018

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dktapps @Yexeed